Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css update #103

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Css update #103

wants to merge 2 commits into from

Conversation

jasomdotnet
Copy link

I have inlined new svg icon right into css using this tool. Less server requests still matter especially in mobile.

@runette runette mentioned this pull request Dec 31, 2019
hswong3i added a commit to drustack/Leaflet-Leaflet.fullscreen that referenced this pull request Nov 26, 2021
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to drustack/Leaflet-Leaflet.fullscreen that referenced this pull request Nov 30, 2021
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
runette pushed a commit to runette/Leaflet.fullscreen that referenced this pull request May 13, 2022
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant